38 lines
1.3 KiB
Diff
38 lines
1.3 KiB
Diff
From b638a74c3b16e0781bb25478c135726862c9271d Mon Sep 17 00:00:00 2001
|
|
From: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
|
|
Date: Wed, 5 Feb 2025 11:25:19 +0000
|
|
Subject: cpufreq/amd-pstate: Remove the unnecessary cpufreq_update_policy call
|
|
|
|
The update_limits callback is only called in two conditions.
|
|
|
|
* When the preferred core rankings change. In which case, we just need to
|
|
change the prefcore ranking in the cpudata struct. As there are no changes
|
|
to any of the perf values, there is no need to call cpufreq_update_policy()
|
|
|
|
* When the _PPC ACPI object changes, i.e. the highest allowed Pstate
|
|
changes. The _PPC object is only used for a table based cpufreq driver
|
|
like acpi-cpufreq, hence is irrelevant for CPPC based amd-pstate.
|
|
|
|
Hence, the cpufreq_update_policy() call becomes unnecessary and can be
|
|
removed.
|
|
|
|
Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
|
|
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
|
|
---
|
|
drivers/cpufreq/amd-pstate.c | 4 ----
|
|
1 file changed, 4 deletions(-)
|
|
|
|
--- a/drivers/cpufreq/amd-pstate.c
|
|
+++ b/drivers/cpufreq/amd-pstate.c
|
|
@@ -853,10 +853,6 @@ static void amd_pstate_update_limits(uns
|
|
sched_set_itmt_core_prio((int)cur_high, cpu);
|
|
}
|
|
cpufreq_cpu_put(policy);
|
|
-
|
|
- if (!highest_perf_changed)
|
|
- cpufreq_update_policy(cpu);
|
|
-
|
|
}
|
|
|
|
/*
|