38 lines
1.3 KiB
Diff
38 lines
1.3 KiB
Diff
From c1a019d5fef8266e444159bc2bdaf9a5c9c7ef76 Mon Sep 17 00:00:00 2001
|
|
From: Alexandra Diupina <adiupina@astralinux.ru>
|
|
Date: Wed, 19 Mar 2025 17:28:58 +0300
|
|
Subject: cifs: avoid NULL pointer dereference in dbg call
|
|
|
|
cifs_server_dbg() implies server to be non-NULL so
|
|
move call under condition to avoid NULL pointer dereference.
|
|
|
|
Found by Linux Verification Center (linuxtesting.org) with SVACE.
|
|
|
|
Fixes: e79b0332ae06 ("cifs: ignore cached share root handle closing errors")
|
|
Cc: stable@vger.kernel.org
|
|
Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
|
|
Signed-off-by: Steve French <stfrench@microsoft.com>
|
|
---
|
|
fs/smb/client/smb2misc.c | 9 +++++----
|
|
1 file changed, 5 insertions(+), 4 deletions(-)
|
|
|
|
--- a/fs/smb/client/smb2misc.c
|
|
+++ b/fs/smb/client/smb2misc.c
|
|
@@ -816,11 +816,12 @@ smb2_handle_cancelled_close(struct cifs_
|
|
WARN_ONCE(tcon->tc_count < 0, "tcon refcount is negative");
|
|
spin_unlock(&cifs_tcp_ses_lock);
|
|
|
|
- if (tcon->ses)
|
|
+ if (tcon->ses) {
|
|
server = tcon->ses->server;
|
|
-
|
|
- cifs_server_dbg(FYI, "tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",
|
|
- tcon->tid, persistent_fid, volatile_fid);
|
|
+ cifs_server_dbg(FYI,
|
|
+ "tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",
|
|
+ tcon->tid, persistent_fid, volatile_fid);
|
|
+ }
|
|
|
|
return 0;
|
|
}
|