rewrite scripts

try to provide better syntax and avoid using bash

debian/templates/headers.postinst.in

@@ -8,9 +8,8 @@ $|=1;
 my $version  = "@abiname@@localversion@";
 
 if (-d "/etc/kernel/header_postinst.d") {
-  system ("run-parts --report --exit-on-error --arg=$version " .
-          "/etc/kernel/header_postinst.d") &&
-            die "Failed to process /etc/kernel/header_postinst.d";
+    system ("run-parts --report --exit-on-error --arg=$version /etc/kernel/header_postinst.d")
+    && die "Failed to process /etc/kernel/header_postinst.d";
 }
 
 exit 0;

debian/templates/image.postinst.in

@@ -1,25 +1,27 @@
-#!/bin/sh -e
+#!/bin/sh
+set -e
 
-version=@abiname@@localversion@
-image_path=/boot/@image-stem@-$version
+[ "$1" = configure ] || exit 0
 
-if [ "$1" != configure ]; then
-    exit 0
-fi
+version='@abiname@@localversion@'
+image_path="/boot/@image-stem@-${version}"
 
-depmod $version
+depmod "${version}"
 
-if [ -f /lib/modules/$version/.fresh-install ]; then
+if command -v linux-update-symlinks >/dev/null ; then
     change=install
-else
-    change=upgrade
-fi
-linux-update-symlinks $change $version $image_path
-rm -f /lib/modules/$version/.fresh-install
+    [ -f "/lib/modules/${version}/.fresh-install" ] || change=upgrade
 
-if [ -d /etc/kernel/postinst.d ]; then
-    DEB_MAINT_PARAMS="$*" run-parts --report --exit-on-error --arg=$version \
-	      --arg=$image_path /etc/kernel/postinst.d
+    linux-update-symlinks "${change}" "${version}" "${image_path}"
+fi
+rm -f "/lib/modules/${version}/.fresh-install"
+
+if [ -d /etc/kernel/postinst.d ] ; then
+    DEB_MAINT_PARAMS="$*" \
+    run-parts --report --exit-on-error \
+      "--arg=${version}" \
+      "--arg=${image_path}" \
+    /etc/kernel/postinst.d
 fi
 
 exit 0

debian/templates/image.postrm.in

@@ -1,31 +1,54 @@
-#!/bin/sh -e
+#!/bin/sh
+set -e
 
-version=@abiname@@localversion@
-image_path=/boot/@image-stem@-$version
+version='@abiname@@localversion@'
+image_path="/boot/@image-stem@-${version}"
 
-rm -f /lib/modules/$version/.fresh-install
+rm -f "/lib/modules/${version}/.fresh-install"
 
-if [ "$1" != upgrade ] && command -v linux-update-symlinks >/dev/null; then
-    linux-update-symlinks remove $version $image_path
+if [ "$1" != upgrade ] && command -v linux-update-symlinks >/dev/null ; then
+    linux-update-symlinks remove "${version}" "${image_path}"
 fi
 
-if [ -d /etc/kernel/postrm.d ]; then
-    DEB_MAINT_PARAMS="$*" run-parts --report --exit-on-error --arg=$version \
-	      --arg=$image_path /etc/kernel/postrm.d
+if [ -d /etc/kernel/postrm.d ] ; then
+    DEB_MAINT_PARAMS="$*" \
+    run-parts --report --exit-on-error \
+      "--arg=${version}" \
+      "--arg=${image_path}" \
+    /etc/kernel/postrm.d
 fi
 
 if [ "$1" = purge ]; then
-    for extra_file in modules.dep modules.isapnpmap modules.pcimap \
-                      modules.usbmap modules.parportmap \
-                      modules.generic_string modules.ieee1394map \
-                      modules.ieee1394map modules.pnpbiosmap \
-                      modules.alias modules.ccwmap modules.inputmap \
-                      modules.symbols modules.ofmap \
-                      modules.seriomap modules.\*.bin \
-                      modules.softdep modules.weakdep modules.devname; do
-	eval rm -f /lib/modules/$version/$extra_file
+    for extra_file in \
+     'modules.*.bin' \
+      modules.alias \
+      modules.ccwmap \
+      modules.dep \
+      modules.devname \
+      modules.generic_string \
+      modules.ieee1394map \
+      modules.inputmap \
+      modules.isapnpmap \
+      modules.ofmap \
+      modules.parportmap \
+      modules.pcimap \
+      modules.pnpbiosmap \
+      modules.seriomap \
+      modules.softdep \
+      modules.symbols \
+      modules.usbmap \
+      modules.weakdep \
+    ; do
+        case "${extra_file}" in
+        *\** | *\?* )
+            find "/lib/modules/${version}/" -mindepth 1 -maxdepth 1 -name "${extra_file}" -exec rm -f {} +
+        ;;
+        * )
+            rm -f "/lib/modules/${version}/${extra_file}"
+        ;;
+        esac
     done
-    rmdir /lib/modules/$version || true
+    rmdir "/lib/modules/${version}" || true
 fi
 
 exit 0

debian/templates/image.preinst.in

@@ -1,21 +1,23 @@
-#!/bin/sh -e
+#!/bin/sh
+set -e
 
-version=@abiname@@localversion@
-image_path=/boot/@image-stem@-$version
+if [ "$1" = abort-upgrade ] ; then exit 0 ; fi
 
-if [ "$1" = abort-upgrade ]; then
-    exit 0
-fi
+version='@abiname@@localversion@'
+image_path="/boot/@image-stem@-${version}"
 
 if [ "$1" = install ]; then
     # Create a flag file for postinst
-    mkdir -p /lib/modules/$version
-    touch /lib/modules/$version/.fresh-install
+    mkdir -p "/lib/modules/${version}"
+    touch "/lib/modules/${version}/.fresh-install"
 fi
 
-if [ -d /etc/kernel/preinst.d ]; then
-    DEB_MAINT_PARAMS="$*" run-parts --report --exit-on-error --arg=$version \
-	      --arg=$image_path /etc/kernel/preinst.d
+if [ -d /etc/kernel/preinst.d ] ; then
+    DEB_MAINT_PARAMS="$*" \
+    run-parts --report --exit-on-error \
+      "--arg=${version}" \
+      "--arg=${image_path}" \
+    /etc/kernel/preinst.d
 fi
 
 exit 0

debian/templates/image.prerm.in

@@ -1,17 +1,21 @@
-#!/bin/sh -e
+#!/bin/sh
+set -e
 
-version=@abiname@@localversion@
-image_path=/boot/@image-stem@-$version
+[ "$1" = remove ] || exit 0
 
-if [ "$1" != remove ]; then
-    exit 0
+version='@abiname@@localversion@'
+image_path="/boot/@image-stem@-${version}"
+
+if command -v linux-check-removal >/dev/null ; then
+    linux-check-removal "${version}"
 fi
 
-linux-check-removal $version
-
-if [ -d /etc/kernel/prerm.d ]; then
-    DEB_MAINT_PARAMS="$*" run-parts --report --exit-on-error --arg=$version \
-	      --arg=$image_path /etc/kernel/prerm.d
+if [ -d /etc/kernel/prerm.d ] ; then
+    DEB_MAINT_PARAMS="$*" \
+    run-parts --report --exit-on-error \
+      "--arg=${version}" \
+      "--arg=${image_path}" \
+    /etc/kernel/prerm.d
 fi
 
 exit 0